work around mock (COPR) regression #1693
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances error handling by adding more context to operations that might fail, which is a great improvement for debuggability. The changes in crates/ostree-ext/src/globals.rs correctly use anyhow::Context and fn-error-context to wrap potential errors with descriptive messages. I have one piece of feedback regarding a likely missing import for the #[context] attribute macro.
This suddenly started in our RPM (COPR/mock) builds, my suspicion
is that seccomp got turned on inadvertently, but let's
add some error context here on general principle.
```
thread 'boundimage::tests::test_parse_spec_dir' panicked at crates/lib/src/boundimage.rs:290:49:
called `Result::unwrap()` on an `Err` value: Querying bound images
Caused by:
Function not implemented (os error 38)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
Signed-off-by: Colin Walters <[email protected]>
cgwalters
changed the title
cgwalters
changed the title
|
Man I really should have looked carefully at the full list of failing tests. There were a ton from the importer failing, but that wasn't all of it. This seccomp profile turns of all use of openat2 which is going to be painful to work around consistently; we also use it in the linting code, etc. |
|
OK I just turned off all the unit tests in the RPM build if we detect seccomp for now. We already do run the unit tests inside the container build, and this only affects COPR not production Koji so there's no real coverage loss. |
Workaround for rpm-software-management/mock#1613 (comment) Signed-off-by: Colin Walters <[email protected]>
|
@henrywang you're assigned reviewer this cycle, can you take this? |
2 participants
This suddenly started in our RPM (COPR/mock) builds, my suspicion is that seccomp got turned on inadvertently, but let's add some error context here on general principle.